Change Bower to NPM. #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hamrak
commented
Jul 5, 2018
•
hamrak
commented
| Q | A |
|---|---|
| Is bugfix? | yes |
| New feature? | no |
| Breaks BC? | no |
| Tests pass? | yes |
| Fixed issues | #35 |
|
@samdark What do you think? Will there be a switch to npm in the other repos? |
|
I think switching to npm makes sense for this package. |
cebe
reviewed
Oct 18, 2018
| @@ -37,7 +37,8 @@ | |||
| ], | |||
| "require": { | |||
| "yiisoft/yii2": "~2.0|~2.1@dev|~3.0@dev", | |||
| "bower-asset/bootstrap": "~4.0" | |||
| "npm-asset/bootstrap": "~4.1", | |||
| "npm-asset/popper.js": "~1.14.3" | |||
There was a problem hiding this comment.
there is no dist directory in popper.js repo on non-stable versions:
https://github.com/FezVrasta/popper.js
We need to add the @stable tag here, to ensure we have assets we can publish.
Suggested change
| "npm-asset/popper.js": "~1.14.3" | |
| "npm-asset/popper.js": "~1.14.3@stable" |
There was a problem hiding this comment.
This is the same as we have with jquery here:
|
Hi @snickom, We'd like to publish the first release of this package soon. Could you take care of fixing conflicts and applying the suggested change to |
|
I make another pull request ( #85 ) with fixed composer.json, because I lost my old forked repository, sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.