Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise min version to PHP 7.3, check compatibility PHP 8.3. #346

Merged
merged 6 commits into from
Jun 16, 2024

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

@what-the-diff
Copy link

what-the-diff bot commented Sep 28, 2023

PR Summary

  • Updated Automation Workflow Inclusion Policy
    The code automation workflow file was updated to set certain paths to be ignored during the 'pull request' and 'push' events. This means the workflow will not be triggered when the specified paths are changed in the codebase.

  • Adjusted PHP Version Requirement and PHPUnit Dependency
    The requirement for the minimum version of PHP was increased to version 7.3 to ensure smooth functioning. Also, a test-building tool we use, called PHPUnit, had its version upgraded to 9.6, therefore allowing us to benefit from its latest features.

  • Standardized 'setUp' Methods with Return Type Declarations
    For consistency and improved readability, the 'setUp' method in several test file structures were modified to include specific return type declarations. This change affects the ActiveDataProviderTest.php, ActiveQueryTest.php, ActiveRecordTest.php, CommandTest.php, ConnectionTest.php, ElasticsearchTargetTest.php, QueryBuilderTest.php, QueryTest.php, and TestCase.php files.

  • Increased Assertion Checks in Test Methods
    Salesforce-related methods, like testSearch and testSuggestion in the ActiveRecordTest.php file, and testViaWithCallable in ActiveRecordTestTrait.php, were strengthened by adding more assertion checks. This ensures that these methods are working as expected in all conditions.

  • Version-specific Assertion in testRuntimeMappings Method
    The testRuntimeMappings method in QueryTest.php was modified to only run assertions if the Elasticsearch version is 7.11.0 or later, making the tests more efficient by preventing them to run unnecessarily on unsupported versions.

  • Cleanup of Unused Files
    Obsolete or non-required files like tests/compatibility.php were removed from the project.

@codecov
Copy link

codecov bot commented Sep 29, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@samdark samdark marked this pull request as ready for review June 16, 2024 15:59
@samdark samdark merged commit dec1ea0 into yiisoft:master Jun 16, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants