Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6043 Added support for array type styles and classes #8458

Merged
merged 4 commits into from
May 27, 2015

Conversation

klimov-paul
Copy link
Member

Fix #6043 Added support for array type styles and classes.
BC kept.

Pay attention for unit test HtmlTest::testMergeCssClass(): it demonstrates the solution for issues like:
#8229
#4916

yiisoft/yii2-bootstrap#15

@samdark
Copy link
Member

samdark commented May 18, 2015

Nice!

@alexandernst
Copy link

Nice to see this :)
Should I close #8229 @cebe @klimov-paul ?

@klimov-paul
Copy link
Member Author

First of all, the whole team should accept the approach.
Then we need to decide, which key should be used for classes added by Yii.
I whould like to use 'widget' for the classes added by widgets.

@alexandernst
Copy link

Attention ping @yii-devs :)
This is something quite important, imho, so the sooner it gets discussed and merged, the better.

@samdark
Copy link
Member

samdark commented May 24, 2015

Well, I like the approach. @qiangxue, @cebe thoughts?

@cebe
Copy link
Member

cebe commented May 26, 2015

looks great to me :)

@klimov-paul
Copy link
Member Author

Relates: yiisoft/yii2-bootstrap#52

@klimov-paul klimov-paul deleted the 6043-html-arrays branch June 6, 2015 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for array type styles.
4 participants