update #1
Merged
update #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… '[webView stopLoading]'
Add semicolon after decisionHandler
…opping whole WKWebView.
Print a log instead raising an exception in @select(flushMessageQueue:)
Do away with numRequestsLoading and replace it with additional logic in the "embed snippet" on the webpage side. The way things work now, the webpage includes a snippet code which: 1) checks if WVJB has already been loaded, in case we proceed immediately 2) or else stores the callback in `window.WVJBCallbacks`. 3) waits for the wvjb js code to be injected/loaded, at which point all load callbacks are called
[mod]use 'decisionHandler(WKNavigationActionPolicyCancel)' to replace…
Call policy handler with WKNavigationActionPolicyCancel instead of st…
add support for internet offline fail call
…fault handler and plain `send`.
The 'Usage' describes the latest version 6.0.2 and the 'Installation with CocoaPods' installs the version 5.2.0. So, if someone follows the tutor, the Objc will not connect with javascript. The reason is here #266 (comment) .
because `WVJBIframe.src = 'https://__bridge_loaded__';` is support 6.0 version, doesn't support 5.0 version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before your create your PR:
Please add tests for any new or changed functionality!
Tests/WebViewJavascriptBridgeTests/BridgeTests.mmake testand make sure your test is passingThanks for improving WebViewJavascriptBridge!
Cheers,
@marcuswestin