Use a positive lookahead for regex to also get overlapping matches. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…), so consecutive image tags are also replaced.
|
@woutk88 Your changes is not working because of module's update, Can you give solution for latest module? |
|
Sorry for this long delay. I decided to use DOMDocument to search the HTML for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue where not all images are being replaced when there are consecutive image tags. The first image would be replaced, but the second one would not. This happens because the first part of the second image tag (
<img) is part of the first regex match.I've changed the regex to also find overlapping matches using a 'positive lookahead'. Because lookaheads do not store/consume the match, another (with the original regex)
preg_matchhas been added to actually find the matching parts.This should solve #16 (and I suspect also yireo/Yireo_Webp2#107), however as mentioned in #16 (comment) using a DOM parser might be more reliable.