Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

problem with using .cnt files #48

Closed
neuro-sevas opened this issue Dec 1, 2021 · 3 comments · Fixed by #55
Closed

problem with using .cnt files #48

neuro-sevas opened this issue Dec 1, 2021 · 3 comments · Fixed by #55

Comments

@neuro-sevas
Copy link

In app.py eeg file extension is hard coded for vhdr files only

Line 176: "rules": {'non-bids':{'eeg_extension':'.vhdr'}},
yjmantilla added a commit that referenced this issue Dec 1, 2021
@yjmantilla
fixinb bug from #48
0c4f9c6
@yjmantilla yjmantilla mentioned this issue Dec 1, 2021
Merged
yjmantilla added a commit that referenced this issue Dec 1, 2021
@yjmantilla
Merge pull request #50 from yjmantilla/brainhack
86eaad8 
fixing bug from #48
@yjmantilla
Copy link
Owner

Also related to mne-tools/mne-bids#922

@yjmantilla
Copy link
Owner

I finally was able to merge the PR in mne-bids related to this mne-tools/mne-bids#924

@yjmantilla
Copy link
Owner

yjmantilla commented Jan 13, 2022 •
edited
Loading

what's left is updating sovabids so that now it doesnt ask for my fork of mne-bids but rather the updated version

EDIT: Have to wait until mne releases the updated version.

@yjmantilla yjmantilla mentioned this issue Feb 7, 2022
Merged
yjmantilla added a commit that referenced this issue Feb 7, 2022
@yjmantilla
Merge pull request #55 from yjmantilla/fix-invalid-chars
33d03eb 
- CNT implementation. Closes problem with using .cnt files  #48 , but by requiring the latest dev version of mne-bids. Once they include it on the stable version we should ask for the stable one.
- Fixes bids_validator requirement missing in the user installation mode. This is used in heuristics.py.
- Now if an entity value has '_' or '-', they will be changed to '' automatically to adapt to the bids standard. In the future it would be nice for the user to choose which replacement to do.
- Now, files with problems for conversion or rules applying will be skipped and the corresponding error and filepath will be saved on the log.
- Typo correction. Closes correct typo in documentation #53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix invalid chars yjmantilla/sovabids
2 participants
@yjmantilla @neuro-sevas