Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental Conversion #57

Merged
merged 3 commits into from
Sep 9, 2022
Merged

Incremental Conversion #57

merged 3 commits into from
Sep 9, 2022

Conversation

yjmantilla
Copy link
Owner

@yjmantilla yjmantilla commented Feb 7, 2022

Experimental Feature

  • Adds incremental conversion
  • Currently, no parameter is added to control this. By default it skips file already converted.
  • If the user wants to overwrite he needs to delete the output folder and start sovabids again

closes #23
closes #56

@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #57 (4b190d8) into main (041772d) will increase coverage by 0.09%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   82.70%   82.80%   +0.09%     
==========================================
  Files          15       15              
  Lines         746      756      +10     
==========================================
+ Hits          617      626       +9     
- Misses        129      130       +1     
Impacted Files Coverage Δ
sovabids/convert.py 91.83% <66.66%> (-1.65%) ⬇️
sovabids/loggers.py 89.47% <100.00%> (+2.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 041772d...4b190d8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log filenames and incremental conversion Incremental conversion
1 participant