Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change analyzer name and doc #8

Merged
merged 1 commit into from
Nov 21, 2023
Merged

change analyzer name and doc #8

merged 1 commit into from
Nov 21, 2023

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Nov 20, 2023

The PR changes the linter's name to zerologlint. Also, slightly modifies the linter's doc field.
This is for consistency with zerologlint in the golangci-lint.

After the PR is merged and the new version bumped we can rewrite golangci-lint's code to the:

func NewZerologLint() *goanalysis.Linter {
	a := zerologlint.Analyzer
	return goanalysis.NewLinter(
		a.Name,
		a.Doc,
		[]*analysis.Analyzer{a},
		nil,
	).WithLoadMode(goanalysis.LoadModeTypesInfo)
}

@alexandear alexandear changed the title change linter name and doc according to the ones in golangci-lint change analyzer name and doc Nov 20, 2023
@ykadowak
Copy link
Owner

Thank you for your contribution!

After the PR is merged and the new version bumped we can rewrite golangci-lint's code to the:

Can you elaborate on this? Do we need any change on golangci-lint's side?

@alexandear
Copy link
Contributor Author

Do we need any change on golangci-lint's side?

Yeah, we need a little change. I will do this through a PR to the golangci-lint.

@ykadowak
Copy link
Owner

Yeah, we need a little change. I will do this through a PR to the golangci-lint.

Sounds good. I'll release after merging this.

@ykadowak ykadowak self-requested a review November 21, 2023 15:04
@ykadowak ykadowak merged commit b7e040a into ykadowak:main Nov 21, 2023
2 checks passed
@alexandear alexandear deleted the change-name-doc branch November 21, 2023 16:49
@ykadowak
Copy link
Owner

Released v0.1.4 with this change, so should be bumped on golangci-lint side soon. Can you mention me when you create the PR in golangci-lint repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants