Frontend Coding Challenge v2.0

This project was bootstrapped with Create React App and has addtional libraries included:

• Redux
• Redux Thunk
• React Redux
• styled-components
• polished

Head over to the coding challenge here.

Available Scripts

In the project directory, you can run:

yarn start

Starts the fake REST API server on http://localhost:4000 and runs the app in development mode on http://localhost:3000.

Notes

• The page will reload if you make edits.
• You will also see any TypeScript or lint errors in the console.
• You can re-run the script to reset/regenerate the data.

yarn start:web

yarn start:web

Runs the app in development mode on http://localhost:3000.

Notes

• The page will reload if you make edits.
• You will also see any TypeScript or lint errors in the console.

yarn start:api

yarn start:web

Starts the fake REST API server on http://localhost:4000.

Notes

• You can re-run the script to reset/regenerate the data.

Fake REST API

Running on http://localhost:4000.

/tournaments

GET

Get a list of tournaments.

Query Parameters

q

Type: string

Search tournaments by any value

Response Example

[
    {
        "id": "79218e94-91fd-4420-8278-f453574b97c4",
        "name": "Veritatis Quam Facilis",
        "organizer": "Rerum Perspiciatis",
        "game": "Rocket League",
        "participants": {
            "current": 206,
            "max": 256
        },
        "startDate": "2020-02-27T11:28:02.233Z"
    },
    {
        "id": "042fddd8-882f-4dd3-9cf1-ff82a3c8be9f",
        "name": "Cum Eveniet Quibusdam",
        "organizer": "Id",
        "game": "Dota 2",
        "participants": {
            "current": 168,
            "max": 256
        },
        "startDate": "2020-02-27T11:28:02.233Z"
    },
    {
        "id": "2eb5d07a-8ce5-4b36-8c0f-76b55701d9cc",
        "name": "Numquam Fuga Totam",
        "organizer": "Quaerat Dolorem",
        "game": "Dota 2",
        "participants": {
            "current": 256,
            "max": 256
        },
        "startDate": "2020-02-27T11:28:02.233Z"
    }
]

POST

Create a tournament.

Request Example

{
    "name": "Foo"
}

Response Example

{
    "id": "2b86b928-a0b5-4dec-8b5a-5f3519790829",
    "name": "Foo",
    "organizer": "Voluptas",
    "game": "League of Legends",
    "participants": {
        "current": 204,
        "max": 256
    },
    "startDate": "2020-02-27T11:36:27.047Z"
}

/tournaments/:id

PATCH

Edit a tournament.

Request Example

{
    "name": "Bar"
}

Response Example

{
    "id": "2b86b928-a0b5-4dec-8b5a-5f3519790829",
    "name": "Bar",
    "organizer": "Voluptas",
    "game": "League of Legends",
    "participants": {
        "current": 204,
        "max": 256
    },
    "startDate": "2020-02-27T11:36:27.047Z"
}

DELETE

Delete a tournament.

Response Example

{}

Thoughts on the challenge

I added @redux-devtools/extension for now and further usage, to help debugging the redux store. I added flux-standard-action as guidelines to follow implementing redux actions. I added prettier to clean my code all along the dev process. I updated the scripts to automatically copy the .sample.env file to .env and have later several .env files for different environments. I added reselect library to create memoized selectors for redux.

I added some reducer tests & unit tests for the validateTournamentName function I added a views folder to separate "routes" components from "components", whom are really reusable. I Reordered the components in the components folder following the atomic design pattern. That's opinionated, but I think it's a good practice to follow.

All models exchanged through are in the src/api/modals and should be provided somehow (maybe a swagger.json file to be parsed through open-api-generator) Same for routes described in src/api/client which should be generated as well.

I fixed the typescript declaration for vanilla redux / thunks in the react-app-env.d.ts so that types are correct with the useDispatch. See here: reduxjs/redux-thunk#333 (comment) This has been validated by Marc Erikson himself

I usually use a "duck" organisation for redux like so

    /store
      /tourmanents
        /tourmanents.actions.ts # all actions including thunk actions
        /tourmanents.hooks.ts # all custom hooks to use the thunks actions
        /tourmanents.middlewares.ts # the tournament middleware related code
        /tourmanents.middlewares.spec.ts # all middleware tests
        /tourmanents.reducer.ts # the tournament reducer + initial values
        /tourmanents.reducer.spec.ts # the tournament reducer tests
        /tourmanents.selectors.ts # all tournament selectors
        /tourmanents.selectors.spec.ts # all selectors test, eventually check valid memoization of reselect selectors
        /tourmanents.types.ts # all types here
        /index.ts # export all the above to ease imports later
      /<otherDuck>

I usually use storybook + msw to define then tests my components in isolation and mock backend requests if any. I usually use cypress for e2e critical features, but moving along to playwright as it's more stable and faster.