ASAP-686 CRN Public API changes #4408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4408 +/- ##
=======================================
Coverage 99.46% 99.46%
=======================================
Files 1054 1054
Lines 20372 20374 +2
Branches 6431 6429 -2
=======================================
+ Hits 20263 20265 +2
Misses 109 109 ☔ View full report in Codecov by Sentry. |
lctrt
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA ticket: https://asaphub.atlassian.net/browse/ASAP-686
This part of acceptance
Will be done in another PR as ideally it requires a new Contentful environment
Examples:
https://api-4408.hub.asap.science/public/research-outputs/1QDoTyaLa25aZJNIkGz3RH
https://api-4408.hub.asap.science/public/users/edca36c4-ce51-4937-a892-5e4222954239