-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASAP-813 Allow only lab membership creation on the CMS #4475
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4475 +/- ##
=======================================
Coverage 99.48% 99.48%
=======================================
Files 1086 1086
Lines 21606 21606
Branches 6838 6838
=======================================
Hits 21494 21494
Misses 112 112 ☔ View full report in Codecov by Sentry. |
0ca751a
to
db496aa
Compare
const users = migration.editContentType('users'); | ||
|
||
users.changeFieldControl('labs', 'builtin', 'entryLinksEditor', { | ||
showLinkEntityAction: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually this should be true 😅
packages/contentful/migrations/crn/users/20241213103301-remove-labs-link-existing-entries.js
Outdated
Show resolved
Hide resolved
…-labs-link-existing-entries.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Adding an existing linked entry was causing confusion
so we're going to change it to always create a new lab-membership entry