Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASAP-813 Allow only lab membership creation on the CMS #4475

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

gabiayako
Copy link
Collaborator

@gabiayako gabiayako commented Dec 13, 2024

Adding an existing linked entry was causing confusion

Screenshot 2024-12-13 at 07 39 54

so we're going to change it to always create a new lab-membership entry
Screenshot 2024-12-13 at 08 54 50

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.48%. Comparing base (5ad5faf) to head (1080ca2).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4475   +/-   ##
=======================================
  Coverage   99.48%   99.48%           
=======================================
  Files        1086     1086           
  Lines       21606    21606           
  Branches     6838     6838           
=======================================
  Hits        21494    21494           
  Misses        112      112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gabiayako gabiayako force-pushed the ASAP-813-changes-to-users-content-model branch from 0ca751a to db496aa Compare December 13, 2024 11:29
@gabiayako gabiayako marked this pull request as ready for review December 13, 2024 11:57
const users = migration.editContentType('users');

users.changeFieldControl('labs', 'builtin', 'entryLinksEditor', {
showLinkEntityAction: false,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually this should be true 😅

Copy link
Collaborator

@AkosuaA AkosuaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@gabiayako gabiayako merged commit e863875 into master Dec 13, 2024
63 checks passed
@gabiayako gabiayako deleted the ASAP-813-changes-to-users-content-model branch December 13, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crn-create-environment Creates dedicated contentful CRN environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants