Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASAP-810 Reorder Events in GP2 Dashboard #4484

Merged

Conversation

gabiayako
Copy link
Collaborator

@gabiayako gabiayako commented Dec 18, 2024

This PR makes the events appear in descending event date order.

This is done by passing a boolean to the search function (code reference - https://github.com/yldio/asap-hub/blob/master/packages/algolia/src/client.ts#L232):
descending

Like is done in CRN (code reference - https://github.com/yldio/asap-hub/blob/master/apps/crn-frontend/src/events/api.ts#L30):
crn


Before and after this change
Screenshot 2024-12-18 at 08 51 38

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.48%. Comparing base (1fffd26) to head (741de88).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4484   +/-   ##
=======================================
  Coverage   99.48%   99.48%           
=======================================
  Files        1086     1086           
  Lines       21606    21606           
  Branches     6837     6837           
=======================================
  Hits        21494    21494           
  Misses        112      112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gabiayako gabiayako marked this pull request as ready for review December 18, 2024 11:55
@gabiayako gabiayako merged commit f1170d2 into master Dec 18, 2024
63 checks passed
@gabiayako gabiayako deleted the ASAP-810-gp-2-reorder-dashboard-past-events-descending branch December 18, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants