Fix "Fix renaming bug" #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi !
I had this file moving/renaming bug where dploy doesn't seem to handle files move/rename ("R100" in git diff). I saw your fork and your attempt to fix this bug (commit ea476c1) but it didn't work because if there's no rename, data[2] is undefined so it can't split this var, so it crashes. I think that's why you reverted this commit, isn't it?
So I fixed this issue by checking if data[2] is defined. Now it works like a charm: I was able to deploy my changes on my server without any problem. :)