Fix bug w.r.t. using gradient_checkpoint without tuning embed_tokens and Fix typo of template in langchain_qa.py #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix typo in template string.
Qznan
changed the title
Qznan
changed the title
Qznan
changed the title
|
Thanks for your contribution. As we are now preparing for the next release, we will review this PR after that. |
airaria
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix bug w.r.t. using gradient_checkpoint without tuning embed_tokens. It's also mentioned in the wiki预训练脚本#节省显存小提示. The code basically refers to the latest version of PEFT to solve this problem.
After the fix, one can use
--gradient_checkpointingwhile not using--modules_to_save ${modules_to_save}to run without Exception likeRuntimeError: element 0 of tensors does not require grad and does not have a grad_fnFix typo in template string of langchain_qa.py. Replace '"\nn" with "\n\n".
Related Issue
None