-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add memory-efficient merging script #608
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iMountTai
reviewed
Jun 16, 2023
iMountTai
reviewed
Jun 16, 2023
报错信息容易引起混淆,可删除
iMountTai
approved these changes
Jun 16, 2023
GPT-4 with Code Interpreter made some suggestions. Here are some suggestions on how to improve the code:
Overall, the code seems to be doing a complex task (merging LoRA models with a base model) and appears to be doing it correctly, but these improvements could make the code cleaner, more efficient, and easier to maintain. |
iMountTai
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a memory-efficient merging script (merge_llama_with_chinese_lora_low_mem.py, and related notebooks).
Comparing to the original script, the new script significantly reduces the memory usage for merging LoRAs to the LLaMA model.
Estimated max memory usage when merging alpaca-lora to the LLaMA with the new script: