Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

bundle of fixes #104

Merged
merged 2 commits into from
Apr 30, 2020
Merged

bundle of fixes #104

merged 2 commits into from
Apr 30, 2020

Conversation

antirotor
Copy link
Member

Bundle of fixes, code changes should be self-explanatory.

@antirotor antirotor added the type: bug Something isn't working label Apr 27, 2020
@antirotor antirotor requested a review from mkolar April 27, 2020 19:53
@antirotor antirotor self-assigned this Apr 27, 2020
@@ -193,6 +193,7 @@ def process(self, instance):
self.log.debug("Output: {}".format(output))

repre_update = {
"anatomy_template": "render",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

damn this will most likely break burnin paths in other sites that original client where this was made. @antirotor
are you sure this is what is running there now?

Or rather we have to update all render templates in anatomy to match the one where this is used. The key point is that we can't be hardcoding render instead of {family} into it. So this needs to be supported by another PR in config

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is addressed in ynput/pype-config#20

@mkolar mkolar merged commit abb980e into master Apr 30, 2020
@mkolar mkolar deleted the hotfix/2.8.1 branch May 13, 2020 21:02
@mkolar mkolar added this to the 2.9 milestone May 25, 2020
Tilix4 added a commit to Tilix4/OpenPype that referenced this pull request May 3, 2023
Tilix4 added a commit to Tilix4/OpenPype that referenced this pull request May 5, 2023
Tilix4 added a commit to Tilix4/OpenPype that referenced this pull request Jun 1, 2023
Tilix4 added a commit to Tilix4/OpenPype that referenced this pull request Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants