Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Ftrack integrate hierarchy fix #1086

Merged
merged 5 commits into from
Mar 5, 2021

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Mar 3, 2021

Issue

  • integrate hierarchy ftrack plugin in hiero does not use hierarchical custom attributes if there is non hierarchical with same key
  • found out there are 2 plugins doing the same (integrate_hierarchy_ftrack.py and integrate_hierarchy_ftrack_SP.py) in plugin for standalone publisher (with _SP suffix) works as should second does not

Changes

  • kept only one plugin where hierarchical attributes are handled properly
  • there are issues with importing pype's ftrack module in Python 2 hosts so imported constant and function from ftrack module lib was added to the plugin without importing (duplicated code with possible issues in future)
🏴 Pype 2.x PR
pype #1085

@iLLiCiTiT iLLiCiTiT self-assigned this Mar 3, 2021
@iLLiCiTiT iLLiCiTiT requested a review from a team March 3, 2021 14:39
@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label Mar 3, 2021
@mkolar mkolar self-requested a review March 5, 2021 10:30
@mkolar mkolar merged commit ce9bfc6 into develop Mar 5, 2021
@mkolar mkolar deleted the bugfix/3_ftrack_integrate_hierarchy_fix branch March 12, 2021 16:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants