Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

PS - group all published instances #1416

Merged
merged 11 commits into from
May 6, 2021

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Apr 27, 2021

Closes: pypeclub/client#56

2.x version: #1415

@kalisp kalisp added the type: enhancement Enhancements to existing functionality label Apr 27, 2021
@kalisp kalisp added this to the 3.0.0-rc1 milestone Apr 27, 2021
@kalisp kalisp requested review from mkolar and 64qam April 27, 2021 15:38
@kalisp kalisp self-assigned this Apr 27, 2021
@kalisp kalisp changed the title 3.0/feature/ps group subset by task name PS - group all published instances Apr 27, 2021
@kalisp kalisp added host: Photoshop sponsored Client endorsed or requested labels Apr 27, 2021
@kalisp kalisp marked this pull request as draft April 27, 2021 16:39
@kalisp
Copy link
Member Author

kalisp commented Apr 27, 2021

For Pype 3 profiles in Settings will be used to allow this functionality for all hosts.

@kalisp
Copy link
Member Author

kalisp commented Apr 29, 2021

Implemented profiles, could be configured in Project Settings > Global > Publish > IntegrateAssetNew
Screenshot 2021-04-29 175603

Currently implemented only task and family placeholders (and their uppercase variants). Any ideas about additional placeholders welcomed.

@kalisp kalisp marked this pull request as ready for review April 29, 2021 15:58
@64qam
Copy link
Member

64qam commented Apr 30, 2021

Looks good

openpype/plugins/publish/integrate_new.py Outdated Show resolved Hide resolved
openpype/plugins/publish/integrate_new.py Outdated Show resolved Hide resolved
Implementation should follow Create subset name approach
"families": instance.data["family"],
"hosts": instance.data["anatomyData"]["app"],
"tasks": instance.data["anatomyData"]["task"] or
io.Session["AVALON_TASK"]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continuation line unaligned for hanging indent

@kalisp
Copy link
Member Author

kalisp commented May 4, 2021

Implemented new function plugin_tools.prepare_template_data to standardize preparation of data for template filling.

Implemented host, subset, renderlayer keys

@mkolar mkolar self-requested a review May 4, 2021 14:25
@mkolar mkolar modified the milestones: 3.0.0-rc1, 3.0.0 May 6, 2021
@mkolar mkolar merged commit b59da71 into develop May 6, 2021
@mkolar mkolar deleted the 3.0/feature/PS_group_subset_by_task_name branch May 6, 2021 18:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Photoshop sponsored Client endorsed or requested type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants