Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Validation of dynamic items in settings #1462

Merged
merged 5 commits into from
May 4, 2021

Conversation

iLLiCiTiT
Copy link
Member

Issue

  • dynamic items does not have validated schemas (children of list or dict-modifiable items)

Changes

  • on schema validation of items with dynamic children is created one temporary item and schema is validated on it (item is removed afterwards)
  • fixed invalid schema data

How to replicate bug

This may cause multiple issues one of them is duplicated key in dict item under dict-modifiable.

  1. go to system settings schemas and open schema_tools.json
  2. duplicate "environment" child under tool_groups key
  3. open Settings UI
  • you will see invalid value (red color) but you should see warning dialog which says that schema was validated

@iLLiCiTiT iLLiCiTiT self-assigned this May 4, 2021
@iLLiCiTiT iLLiCiTiT added backend type: bug Something isn't working labels May 4, 2021
@iLLiCiTiT iLLiCiTiT requested a review from a team May 4, 2021 11:57
@mkolar mkolar added this to the 3.0.0-rc1 milestone May 4, 2021
@mkolar mkolar merged commit c535417 into develop May 4, 2021
@mkolar mkolar deleted the bugfix/dynamic_item_schema_validations branch May 4, 2021 14:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants