Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Simple tvpaint publish #1555

Merged
merged 3 commits into from
May 25, 2021
Merged

Simple tvpaint publish #1555

merged 3 commits into from
May 25, 2021

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented May 21, 2021

Changes

  • review instance is always created even if review is not in instances of workfile metadata
    • subset name is hardcoded to "reviewMain"
  • instances without "uuid" in data are skipped on pyblish plugin toggle callback
  • removed review creator
    • we should maybe keep this creator to be able change subset name of review?

Closes https://github.com/pypeclub/client/issues/67

@iLLiCiTiT iLLiCiTiT self-assigned this May 21, 2021
@iLLiCiTiT iLLiCiTiT requested review from 64qam and mkolar May 21, 2021 09:16
@iLLiCiTiT iLLiCiTiT added backend type: enhancement Enhancements to existing functionality labels May 21, 2021
@iLLiCiTiT iLLiCiTiT requested a review from tokejepsen May 21, 2021 09:17
@tokejepsen
Copy link
Member

Sorry, dont quite get this. Can the user disable/toggle the review still in the Pyblish window?
Just wanna make sure users can publish faster by only outputting what is needed.

@mkolar
Copy link
Member

mkolar commented May 21, 2021

Can the user disable/toggle the review
Yes of course.

The point of this is to make it as easy a quick as possible for artists that maybe don't have full training, to open a scene, do some work and publish with simple review without having to use creator. Production request to make life easier for freelancers.

@tokejepsen
Copy link
Member

The point of this is to make it as easy a quick as possible for artists that maybe don't have full training, to open a scene, do some work and publish with simple review without having to use creator. Production request to make life easier for freelancers.

Sorry, yeah I get that and agree. Just wanna make sure advanced users still have options.

@mkolar
Copy link
Member

mkolar commented May 21, 2021

@tokejepsen just noticed, that my "Yes, of course" got lost in the quote in the previous post. So just to make sure. Yes, it should be possible to disable the review just as any other instance ;)

Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a code from I'm happy with this. @64qam could you please check functionality?

@mkolar mkolar merged commit 4271e1d into develop May 25, 2021
@mkolar mkolar deleted the feature/simple_tvpaint_publish branch May 25, 2021 19:26
@mkolar mkolar added this to the 3.0.0-rc.6 milestone May 27, 2021
@mkolar mkolar added the sponsored Client endorsed or requested label May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
sponsored Client endorsed or requested type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants