This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 129
Add support for multiple Deadline ☠️➖ servers #1905
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iLLiCiTiT
reviewed
Aug 6, 2021
openpype/modules/deadline/plugins/publish/validate_deadline_connection.py
Show resolved
Hide resolved
antirotor
changed the title
Add support for multiple Deadline servers
Add support for multiple Deadline ☠️ servers
Aug 6, 2021
antirotor
changed the title
Add support for multiple Deadline ☠️ servers
Add support for multiple Deadline ☠️➖ servers
Aug 6, 2021
antirotor
added
sponsored
Client endorsed or requested
host: Maya
module: Deadline
AWS Deadline related features
labels
Aug 6, 2021
iLLiCiTiT
reviewed
Aug 6, 2021
iLLiCiTiT
reviewed
Aug 6, 2021
openpype/modules/deadline/plugins/publish/collect_default_deadline_server.py
Outdated
Show resolved
Hide resolved
iLLiCiTiT
reviewed
Aug 6, 2021
iLLiCiTiT
reviewed
Aug 6, 2021
iLLiCiTiT
reviewed
Aug 6, 2021
iLLiCiTiT
reviewed
Aug 12, 2021
get_asset) | ||
from openpype.modules import ModulesManager | ||
|
||
from avalon.api import Session | ||
|
||
|
||
class CreateRender(plugin.Creator): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it ok to require access to deadline server to be able create render?
- I can't create the instance in home and then send it to studio...
It seems there are added callbacks to changes of comboboxes (not sure as I couldn't create because of missing deadline). I'm not sure how callbacks would work after reopening scene?
mkolar
approved these changes
Aug 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
This is adding support for multiple Deadline servers for OpenPype 3.
Changes in Settings
Deadline Module in System Settings now have ability to specify multiple keys for Deadline URLs.
default
is changeable but cannot be deleted and is used through pipeline if nothing else is defined.In Project Settings -> Deadline there is now multiselect enum that allows setting specific Deadline Servers for project.
Publishing
It is up to Creator in specific host how it will handle this feature. Currently implemented in Maya it uses this code to get available servers for project:
In the rest of the publishing pipeline - in publish plugins you can get default Deadline URL from context:
🗒️ this is now collected by new collector*
Support for this was added to all Deadline plugins but it needs host specific initial entry point (probably in render instance creator) to allow user to select desired server. That is currently implemented only in Maya.
Related to #1483