This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 129
Nuke: unified clip loader #2128
Merged
jakubjezek001
merged 14 commits into
develop
from
feature/PYPE-1907_nuke--OpenPype-switch-asset-not-working-
Oct 15, 2021
Merged
Nuke: unified clip loader #2128
jakubjezek001
merged 14 commits into
develop
from
feature/PYPE-1907_nuke--OpenPype-switch-asset-not-working-
Oct 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obsolete way of accessing nodes
integrating video file loading
creating parent nukeLoader
Task linked: PYPE-1907 nuke : OpenPype switch asset not working |
jakubjezek001
commented
Oct 14, 2021
] | ||
representations = [ | ||
"exr", | ||
"dpx", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here are supported extensions/representations for the LoadClip
jrsndl
approved these changes
Oct 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me.
jakubjezek001
deleted the
feature/PYPE-1907_nuke--OpenPype-switch-asset-not-working-
branch
October 15, 2021 12:18
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment Openpype Nuke is using two different loaders for loading image sequence and video files. This was causing trouble when the user wanted to use Inventory Asset Switch in case of switching from video file to image sequence. For that reason a Repair Inventory action has to be written, for repairing old video and sequence loaders. The New LoadClip plugin is now replacing Load Sequence and LoadMov. So in case a production is ongoing and those two loaders were used, user has to first repair those containers in inventory manager and then he can update to newer available version.
To be able to implement Retiming Loader feature the concept of
containerId
knob, shared across all loaded nodes, had to be introduced. In reality, this is solving the long lasted bug which was prevailing to update timewarp / retime nodes and those had to be previously removed manually. The used concept had been inspired by following idea shared by @davidlatwe avalon-core:issue:474.Since there was more class methods which needed to be created for
members
treatment, and also those might come handy also in other loaders lately. This had been added to new abstract class child ofavalon.api.Loader
.Also the improvement of Settings definitions for LoadClip had been introduced. Representations are now Added to those which are set by default in Class attributes instead of overiding them by Settings. It had to be treated in Avalon-core as the required feature was not available in the disocvery plugins function.
Solving: https://support.pype.club/a/tickets/763
Testing Notes
Nuke-menu/OpenPype/Manager
and select andy of loaded containers and RMB click and go to actions and chose the repair action (red with gears)Settings/Project setting/Nuke/Load/LoadClip
and add them intoRepresentaions
Dependencies:
avalon-core: ynput/avalon-core#376