-
Notifications
You must be signed in to change notification settings - Fork 129
Deadline Maya rendering pyblish plugin "override output" option #2273
Deadline Maya rendering pyblish plugin "override output" option #2273
Conversation
394ed34
to
c1e6f41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the path check it is working great and I'll be happy to merge it.
if override: | ||
workspace = cmds.workspace(q=True, rootDirectory=True) | ||
cmds.workspace(root, openWorkspace=True) | ||
|
||
filename_0 = cmds.renderSettings( | ||
fullPath=True, | ||
gin="#" * int(padding), | ||
lut=True, | ||
layer=renderlayer or lib.get_current_renderlayer())[0] | ||
filename_0 = re.sub('_<RenderPass>', '_beauty', | ||
filename_0, flags=re.IGNORECASE) | ||
|
||
if override: | ||
cmds.workspace(workspace, openWorkspace=True) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is problematic, because if directory specified in override doesn't exist, it will fail there and apart of publishing failure, you'll end up with "corrupted" opened scene (it will have wrong project set). Now it could be solved by context manager or at least by validator checking if override location is valid maya project (that it exists). I personally vote for both validator and for context manager here handling failures.
c1e6f41
to
44eb576
Compare
44eb576
to
c22763f
Compare
@antirotor could you give this one more look please? Not sure if we can do anything about it on our end. @jlorrain are you guys using this in production right now? |
I agree we should close this as its a bit too dangerous and there doesn't seem to be any real demand for this among current users. |
Add an "override output" option to the maya render selection set
Why
Allow the operator to override the project rendering output path to perform rendering tests.
How
You can now specify an output path within the Override Output field in the extra attributes of the maya rendering selection set
This Path will be used to set the "OutputFilePath" and the "OutputDirectory" submission parameters of the deadline Plugin and Job