This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Houdini: Remove broken unique name counter #2450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is related to this PR for Avalon Core: ynput/avalon-core#404 |
mkolar
added
type: enhancement
mkolar
approved these changes
Jan 10, 2022
mkolar
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
This removes the unique name counter in some Houdini loaders and resolves #2449.
However, it requires a change in
avalon.houdini.pipelineas well.In particular this line should be changed to:
With this change the
children_as_stringmethod can also be removed fromavalon.houdini.libsince it's only used throughout the code base for these two loaders.