This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 129
General: Add vendors from avalon #2848
Merged
iLLiCiTiT
merged 10 commits into
develop
from
enhancement/OP-2841_Add-vendors-from-avalon
Mar 9, 2022
Merged
General: Add vendors from avalon #2848
iLLiCiTiT
merged 10 commits into
develop
from
enhancement/OP-2841_Add-vendors-from-avalon
Mar 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Task linked: OP-2841 Add vendors from avalon |
jakubjezek001
approved these changes
Mar 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested on macos Flame and it was ok
BigRoy
reviewed
Mar 8, 2022
BigRoy
reviewed
Mar 8, 2022
openpype/lib/vendor_bin_utils.py
Outdated
@@ -86,6 +86,41 @@ def find_executable(executable): | |||
return None | |||
|
|||
|
|||
def create_hard_link(src_path, dst_path): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this function be called create_hardlink
? Since the name of the actual feature is "hardlink" without a space, right?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Add vendors from avalon into openpype dependencies.
Description
Some modules already are part of openpype dependencies but the rest have to be added into our system.
Changes
filelink
with new functioncreate_hard_link
qargparse
intoopenpype/vendor
qtawesome
into poetryqtpy
jsonschema
in poetry was lowered from3.2.0
to2.6.0
functools32
into python 2 vendor filesTesting notes
create_env
scriptqargparse
(loaders)qtawesome
inside hostsflame
@jakubjezek001 please try ui tools theremaya2018
@antirotor if possible?Depends on ynput/avalon-core#426