Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

General: Add vendors from avalon #2848

Merged
merged 10 commits into from
Mar 9, 2022

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Mar 7, 2022

Brief description

Add vendors from avalon into openpype dependencies.

Description

Some modules already are part of openpype dependencies but the rest have to be added into our system.

Changes

  • replaced filelink with new function create_hard_link
  • added qargparse into openpype/vendor
  • added qtawesome into poetry
    • has dependency qtpy
  • jsonschema in poetry was lowered from 3.2.0 to 2.6.0
  • added functools32 into python 2 vendor files

Testing notes

Depends on ynput/avalon-core#426

@mkolar
Copy link
Member

mkolar commented Mar 7, 2022

Task linked: OP-2841 Add vendors from avalon

@iLLiCiTiT iLLiCiTiT self-assigned this Mar 7, 2022
@iLLiCiTiT iLLiCiTiT added the type: refactor Structural changes not affecting functionality label Mar 7, 2022
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on macos Flame and it was ok

@@ -86,6 +86,41 @@ def find_executable(executable):
return None


def create_hard_link(src_path, dst_path):
Copy link
Collaborator

@BigRoy BigRoy Mar 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this function be called create_hardlink? Since the name of the actual feature is "hardlink" without a space, right?

Nevermind, with the underscore I guess is fine.

@iLLiCiTiT iLLiCiTiT merged commit d2a56ff into develop Mar 9, 2022
@iLLiCiTiT iLLiCiTiT deleted the enhancement/OP-2841_Add-vendors-from-avalon branch March 9, 2022 17:58
@mkolar mkolar added this to the 3.9.0 milestone Mar 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: refactor Structural changes not affecting functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants