Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Maya: better handling of legacy review subsets names #3269

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Jun 1, 2022

Brief description

Multiple reviews from a Maya workfile are blocked by legacy subset names without variant. These names could be used in later process so we cannot replace them, see #424 (comment).

Description

Legacy subset name ({task}Review}) is queried for presence in DB for published asset. If at least one subset found, subset name is kept (which limits possibility of multiple reviews), in other case proper from Creator (which could be configured by
Validator to check uniqueness of subset names was added to catch multiple reviews with legacy name.

Solves #3034

Testing notes:

Test A
0. Before pulling this PR create camera and Review instance in Maya and publish

  1. Create at least 2 cameras in Maya
  2. create for them 'Review' instances
  3. Publish
  4. It should fail on Validation

Test B
0. Use different asset then in Test A

  1. Create at least 2 cameras in Maya
  2. create for them 'Review' instances
    1. Publish
  3. It shouldnt fail on Validation

Multiple reviews from a Maya workfile are blocked by legacy subset names without variant. These names could be used in later process so we cannot replace them.
Unique subset name validator was added, check for existing subset in DB too.
@kalisp kalisp self-assigned this Jun 1, 2022
@ynbot
Copy link
Contributor

ynbot commented Jun 1, 2022

Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

multiple reviews work as expected

image

now we should have a look at the broken arbitrary attributes of the review instance

image

@kalisp kalisp merged commit 9825529 into develop Jun 1, 2022
@kalisp kalisp deleted the bugfix/OP-3068_Cannot-publish-multiple-review-subsets-in-Maya branch June 1, 2022 15:16
@mkolar mkolar added the type: enhancement Enhancements to existing functionality label Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Maya type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants