This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Maya: better handling of legacy review subsets names #3269
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Multiple reviews from a Maya workfile are blocked by legacy subset names without variant. These names could be used in later process so we cannot replace them, see #424 (comment).
Description
Legacy subset name (
{task}Review}
) is queried for presence in DB for published asset. If at least one subset found, subset name is kept (which limits possibility of multiple reviews), in other case proper from Creator (which could be configured byValidator to check uniqueness of subset names was added to catch multiple reviews with legacy name.
Solves #3034
Testing notes:
Test A
0. Before pulling this PR create camera and Review instance in Maya and publish
Test B
0. Use different asset then in Test A