Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Calculate size #374

Merged

Conversation

tokejepsen
Copy link
Member

  • option to only calculate without deletion

- option to only calculate without deletion
@tokejepsen tokejepsen added type: enhancement Enhancements to existing functionality module: Ftrack labels Jul 23, 2020
@tokejepsen tokejepsen self-assigned this Jul 23, 2020
@mkolar
Copy link
Member

mkolar commented Jul 28, 2020

This works well, however if you run this on a bigger stack of versions it might take a while and showing the result in the notification might be missed. Could this be tweaked to show the result in another interface widget that replaces the first one? Ideally it would tell you the size, and user could just continue in removing calculated files.

@tokejepsen what do you think?

@tokejepsen
Copy link
Member Author

I've logged the size as well, so it persistent there. Dunno what the intent of the logging is for the end user?

Only other way would be to display the interface again, but not sure the action handlers are designed for this? @iLLiCiTiT

@iLLiCiTiT
Copy link
Member

Only other way would be to display the interface again, but not sure the action handlers are designed for this?

It is possible and there are few approaches for that, all of them must be handled properly... One possible approach is in action_delete_asset.py. I can look into that when I'll get back from holiday.

@tokejepsen
Copy link
Member Author

Last option is to show a job, which might be good anyways to show progression. The job title could be the size.

@tokejepsen
Copy link
Member Author

I might take this logic into a Library Loader instead; #396

@mkolar
Copy link
Member

mkolar commented Aug 6, 2020

@tokejepsen @iLLiCiTiT
I'm happy to merge this and update later on.

@mkolar mkolar merged commit 16f3854 into ynput:2.x/develop Aug 6, 2020
@tokejepsen tokejepsen deleted the 2.x/feature/ftrack_action_delete_size branch August 6, 2020 09:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
module: Ftrack type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants