Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Fixed wrong order of "other" category collapssing in publisher #435

Merged
merged 3 commits into from
Aug 17, 2020

Conversation

iLLiCiTiT
Copy link
Member

Issue

Other group is collapsed with integrators

Changes

Changed group collapsing logic

Resolves: #431

@iLLiCiTiT iLLiCiTiT self-assigned this Aug 12, 2020
Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

./pype/tools/pyblish_pype/model.py:965:34: B008: Do not perform function call...
./pype/tools/pyblish_pype/model.py:965:34: B008: Do not perform function calls in argument defaults.  The call is performed only once at function definition time. All calls to your function will reuse the result of that definition-time function call.  If this is intended, assign the function call to a module-level variable and use that variable as a default value.
./pype/tools/pyblish_pype/model.py:969:31: B008: Do not perform function calls in argument defaults.  The call is performed only once at function definition time. All calls to your function will reuse the result of that definition-time function call.  If this is intended, assign the function call to a module-level variable and use that variable as a default value.
./pype/tools/pyblish_pype/model.py:994:41: B008: Do not perform function calls in argument defaults.  The call is performed only once at function definition time. All calls to your function will reuse the result of that definition-time function call.  If this is intended, assign the function call to a module-level variable and use that variable as a default value.

@iLLiCiTiT iLLiCiTiT requested a review from a team August 12, 2020 17:52
@mkolar mkolar added this to the 2.12 milestone Aug 13, 2020
@mkolar mkolar merged commit ad0b48a into 2.x/develop Aug 17, 2020
@mkolar mkolar added the type: bug Something isn't working label Aug 17, 2020
@mkolar mkolar changed the title Bugfix/other order collapsing Fixed wrong order of "other" category collapssing in publisher Aug 17, 2020
@mkolar mkolar deleted the bugfix/other_order_collapsing branch September 9, 2020 16:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants