-
Notifications
You must be signed in to change notification settings - Fork 129
Conversation
…ications to the main code base that would be required to get it properly functional
It's good to note that this PR adds over 75 MB to the files that get added to each |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this file need to be here? Is this a development tool to fix a specific vendorized file? It seems a bit documented and maybe even unused?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a hang over from when I was trying to get this to be compatible with py2.
I gave up as there was a massive mess around the typing module and numerous other headaches of back porting our in house py3 only code to work with py2.
I will remove the file, but as I understand it, this PR is not to be merged just yet but was requested to see what I have done and see the viability of merging with the current version control work being done @ ynput.
It is not in a usable state, as mentioned in the PR description.
RE the vendored P4 files - there is no other way to support multiple python versions, adding P4 as a core dependency to the OpenPype project will mean P4 will only work with py39 and fail to import in any DCC with a different py version.
We are working on communicating with perforce using websockets - that would eliminate the need to have multiple vendorize perforce api for every individual dcc specific python, so this could be then refactored slightly. |
Interesting - are there docs for that, I would be interested to take a look? |
Just a note that as much as this functionality is highly desired until we're done with the websocket perforce connection, it is not viable to merge it. We'll happily keep it open and get back to it once we're ready |
That makes sense, I have changed to a draft. Is there any existing code for this approach that I can take a look at? I have pondered on this for a while and I have a worry that whilst you guys are solving the problem of interfacing with perforce in a novel and potentially clever way, it might be too novel and clever. Please feel free to disregard my concerns if this has all been considered already. |
@munkybutt the native perforce integration has move quite a bit since this PR was openend and because we're splitting OpenPype into ayon-core and individual addons, this PR would have to be re-created to target one of those. Thank you for the contribution, it helped immensely with the perforce work we've done since. |
@mkolar - thanks for the update! |
Changelog Description
Adds version control module
Additional info
Includes system settings to toggle no/off and choose which version control backend to use.
It currently only has a backend for perforce.
Testing notes:
It should start up with no problem, but it won't do anything as it is standalone and contains no modifications to the main code base that would be required to get it properly functional.