-
Notifications
You must be signed in to change notification settings - Fork 129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works with dictionary subkeys {project[name]}
as seen in the bottom center burnin "Libor_Tests"
but When adding those burnins for focalLength
it gets too many decimals/digits. and when trying to limit those via OP Burnins settings focalLength:2f
it gets N/A mm
in the burnins.
Not sure if somehow connected to this PR but I guess yes when in the testing steps...
Should be resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in Nuke
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The focalLength
values differ from maya scene.
For example on frame #1046 instead being 120.11mm
it is 122.64mm
The same is valid for startframe and endframe. Values being off.
Not an issue of this PR. Only if it does work in develop... |
That does sound like an issue of this PR since it's likely due to a time/frame mismatch of the data. It works fine in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When tested in develop
focal length is correct.
So its an issue within this PR and need to be addressed.
So it was found out that there are some differences in fps, which cause that seconds are calculated wrong (24 vs 25 fps). Tried to fix it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog Description
Refactored list value for burnins and fixed command length limit by using temp file for filters string.
Additional info
Burnin script does not print irrelevant warning about not supported subdictionary formattings (it is supported). List values can have multiple list keys in single template and can expect other keys to fill (except timecode). FFmpeg filters are not passed to cli but through temp file and using
-filter_script
command to the file which should fix possible limit of command length.Testing notes:
{project[name]}
){focalLength}