Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

General: Runtime dependencies #5206

Merged
merged 4 commits into from
Jul 5, 2023
Merged

General: Runtime dependencies #5206

merged 4 commits into from
Jul 5, 2023

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Jun 28, 2023 •
edited
Loading

Changelog Description

Defined runtime dependencies in pyproject toml. Moved python ocio and otio modules there.

Additional info

This change makes sure that both modules won't be in PYTHONPATH thus not propagated to launched DCCs, which should fix possible issues e.g. in NukeStudio/Hiero.

Testing notes:

  1. Delete ./.venv if you have any in repository
  2. Run ./tools/create_env
  3. Run ./tools/fetch_thirdparty_libs

Resolves #5138

@ynbot ynbot added size/XS Denotes a PR changes 0-99 lines, ignoring general files Bump Minor Pull requests that update a dependency file type: feature Larger, user affecting changes and completely new things labels Jun 28, 2023
@iLLiCiTiT iLLiCiTiT changed the title General: runtime dependencies General: Runtime dependencies Jun 28, 2023
antirotor
antirotor previously requested changes Jun 28, 2023
View reviewed changes
Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I would just change the print.

tools/fetch_thirdparty_libs.py Outdated Show resolved Hide resolved
BigRoy
BigRoy reviewed Jun 28, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
iLLiCiTiT and others added 2 commits June 28, 2023 16:01
@iLLiCiTiT @antirotor
Fix print
52aec67 
Co-authored-by: Ondřej Samohel <33513211+antirotor@users.noreply.github.com>
@iLLiCiTiT
fix comment in pyproject toml
517d37c
@iLLiCiTiT iLLiCiTiT requested a review from antirotor June 28, 2023 14:04
@iLLiCiTiT iLLiCiTiT dismissed antirotor’s stale review July 5, 2023 08:43

Requested changes resolved

@iLLiCiTiT iLLiCiTiT merged commit 823261c into release/next-minor Jul 5, 2023
@iLLiCiTiT iLLiCiTiT deleted the feature/runtime_dependencies branch July 5, 2023 08:43
@ynbot ynbot added this to the next-minor milestone Jul 5, 2023
iLLiCiTiT added a commit that referenced this pull request Jul 11, 2023
@iLLiCiTiT @antirotor
General: Runtime dependencies (#5206)
301375c 
* moved opentimlineio to runtime dependencies

* fix darwin fetch thirdparty

* Fix print

Co-authored-by: Ondřej Samohel <33513211+antirotor@users.noreply.github.com>

* fix comment in pyproject toml

---------

Co-authored-by: Ondřej Samohel <33513211+antirotor@users.noreply.github.com>
@jakubjezek001 jakubjezek001 modified the milestones: next-minor, next-patch Jul 13, 2023
@BigRoy BigRoy mentioned this pull request Sep 6, 2023
Closed
2 tasks
@MustafaJafar MustafaJafar mentioned this pull request Jul 4, 2024
Closed
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BigRoy BigRoy BigRoy left review comments

@Minkiu Minkiu Minkiu approved these changes

@kalisp kalisp Awaiting requested review from kalisp

@jakubjezek001 jakubjezek001 Awaiting requested review from jakubjezek001

@antirotor antirotor Awaiting requested review from antirotor

Assignees

@antirotor antirotor

Labels
Bump Minor Pull requests that update a dependency file size/XS Denotes a PR changes 0-99 lines, ignoring general files type: feature Larger, user affecting changes and completely new things
Projects
PR reviewing
Archived in project
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@iLLiCiTiT @Minkiu @BigRoy @antirotor @jakubjezek001 @ynbot