-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launcher: Invert the logic of skip opening of last workfile - OP-6968 #118
Merged
iLLiCiTiT
merged 8 commits into
develop
from
enhancement/OP-6968_Invert-the-logic-of-Skip-Opening-of-Last-Workfile
Feb 28, 2024
Merged
Launcher: Invert the logic of skip opening of last workfile - OP-6968 #118
iLLiCiTiT
merged 8 commits into
develop
from
enhancement/OP-6968_Invert-the-logic-of-Skip-Opening-of-Last-Workfile
Feb 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kip-Opening-of-Last-Workfile
ynbot
added
size/XS
type: enhancement
Improvement of existing functionality or minor addition
labels
Feb 26, 2024
iLLiCiTiT
reviewed
Feb 26, 2024
tokejepsen
commented
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iLLiCiTiT the code changes looks good, but it does not save "Skip opening of last workfile" checkbox state.
@iLLiCiTiT this is working now. Could you sign off on the code? |
iLLiCiTiT
approved these changes
Feb 28, 2024
iLLiCiTiT
deleted the
enhancement/OP-6968_Invert-the-logic-of-Skip-Opening-of-Last-Workfile
branch
February 28, 2024 11:27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
This changes the initial toggle of the
Skip opening of last workfile
option in the Launcher, to inherit from theayon+settings://core/tools/Workfiles/last_workfile_on_startup
setting.If an application is not part of the profiles, it'll initially be set to
Skip opening of last workfile
.This does not influence existing settings in the launcher, where a user has enabled
Skip opening of last workfile
.Testing notes:
ayon+settings://core/tools/Workfiles/last_workfile_on_startup
and verify the initial toggle ofSkip opening of last workfile
is set according to the profiles.Skip opening of last workfile
is actually skipping opening of the last workfile.ayon+settings://core/tools/Workfiles/last_workfile_on_startup
, which should initially haveSkip opening of last workfile
enabled.NOTE: In order to test the initial toggle of
Skip opening of last workfile
, it might useful to remove the launcher settings at;C:\Users\[user]\AppData\Local\ynput\ayon\launcher_tool.json