Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launcher: Invert the logic of skip opening of last workfile - OP-6968 #118

Conversation

tokejepsen
Copy link
Member

Changelog Description

This changes the initial toggle of the Skip opening of last workfile option in the Launcher, to inherit from the ayon+settings://core/tools/Workfiles/last_workfile_on_startup setting.

If an application is not part of the profiles, it'll initially be set to Skip opening of last workfile.

This does not influence existing settings in the launcher, where a user has enabled Skip opening of last workfile.

Testing notes:

  1. Test a variety of combinations for ayon+settings://core/tools/Workfiles/last_workfile_on_startup and verify the initial toggle of Skip opening of last workfile is set according to the profiles.
  2. Test Skip opening of last workfile is actually skipping opening of the last workfile.
  3. Test host without a profile in ayon+settings://core/tools/Workfiles/last_workfile_on_startup, which should initially have Skip opening of last workfile enabled.

NOTE: In order to test the initial toggle of Skip opening of last workfile, it might useful to remove the launcher settings at; C:\Users\[user]\AppData\Local\ynput\ayon\launcher_tool.json

@ynbot ynbot added size/XS type: enhancement Improvement of existing functionality or minor addition labels Feb 26, 2024
@tokejepsen tokejepsen marked this pull request as draft February 27, 2024 11:14
Copy link
Member Author

@tokejepsen tokejepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iLLiCiTiT the code changes looks good, but it does not save "Skip opening of last workfile" checkbox state.

@tokejepsen tokejepsen marked this pull request as ready for review February 27, 2024 19:51
@tokejepsen
Copy link
Member Author

@iLLiCiTiT this is working now. Could you sign off on the code?

@iLLiCiTiT iLLiCiTiT merged commit e567c2d into develop Feb 28, 2024
2 checks passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/OP-6968_Invert-the-logic-of-Skip-Opening-of-Last-Workfile branch February 28, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants