Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max & Maya: Make sure validators being shown in the Publisher UI when they set to be optional in AYON setting #201

Conversation

moonyuet
Copy link
Member

Changelog Description

This PR is to make sure validators being shown correctly in the Publisher UI when they are being set to be optional in AYON setting.

Additional info

n/a

Testing notes:

  1. Launch Max/Maya
  2. Create Instances
  3. Toggle the validators optional switch in Max/Maya settings
  4. Check to see whether the validators are being shown in the Publisher UI

…ose whether it should be included in maya/max for validation
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm personally not a fan of just throwing this into ALL validator plug-ins. Some just really aren't meant to ever be optional plus it's more code to maintain - and in the end does more 'logic' per plug-in and thus will be (maybe measurably?) slower to run.

Anyway, I can see how having the consistency might make it 'less error prone' on changes in the future if someone did start exposing one to settings. But half of these plug-ins don't have matching "optional" settings I believe, and thus this logic being implemented now "does nothing meaningful" because the plug-ins are never actually optional.

So I'd recommend just 'fixing' the ones that need fixing - instead of cluttering it across all plug-ins where it doesn't currently do anything useful. OR add them all to the customizable settings?

@m-u-r-p-h-y
Copy link
Member

m-u-r-p-h-y commented Mar 19, 2024

So I'd recommend just 'fixing' the ones that need fixing - instead of cluttering it across all plug-ins where it doesn't currently do anything useful. OR add them all to the customizable settings?

We are not making any new validator optional here, I suppose. We are just fixing the ones that already have optional tag in settings to propagate it to the publishing window so they are really optional.

image

@BigRoy
Copy link
Collaborator

BigRoy commented Mar 19, 2024

So I'd recommend just 'fixing' the ones that need fixing - instead of cluttering it across all plug-ins where it doesn't currently do anything useful. OR add them all to the customizable settings?

We are not making any new validator optional here, I suppose. We are just fixing the ones that already have optional tag in settings to propagate it to the publishing window so they are really optional.

image

Thanks, yes. Kayla just hit me up on discord in a PM as well mentioning these were already in the settings - in that case. Great fixing! 🧑‍🔧

@m-u-r-p-h-y m-u-r-p-h-y merged commit 1456989 into develop Mar 20, 2024
@m-u-r-p-h-y m-u-r-p-h-y deleted the bugfix/AY-4004_Maya-optional-validator-not-shown-in-publish-context branch March 20, 2024 08:24
@moonyuet moonyuet restored the bugfix/AY-4004_Maya-optional-validator-not-shown-in-publish-context branch April 3, 2024 09:40
moonyuet added a commit to ynput/OpenPype that referenced this pull request Apr 3, 2024
@moonyuet moonyuet deleted the bugfix/AY-4004_Maya-optional-validator-not-shown-in-publish-context branch April 3, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants