Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blender: Model publish uv map name validator #224

Merged

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Mar 24, 2024

Changelog Description

Add model publish validator to ensure uv set is named map1.

Additional info

Blender defaults to UV sets named UVMap which can be an issue for a Maya-centric pipeline.
Note that the plug-in is disabled in settings by default.

Testing notes:

  1. Enable validator in settings
  2. Publish a blender cube
  3. It should invalidate and have a working select and repair action

@ynbot ynbot added size/S type: enhancement Improvement of existing functionality or minor addition host: Blender labels Mar 24, 2024
@moonyuet
Copy link
Member

moonyuet commented Mar 24, 2024

I have done simple test with the codes(also glanced the code a little bit), the validators blocks the publishing as expected when the uv names are not being named to map1.
image
But somehow the font of the error report looks a bit strange where the bold text somehow appear to be much bigger than the normal text. If the debug message and the comment above can be resolved, I will approve the ticket.
image

@BigRoy
Copy link
Collaborator Author

BigRoy commented Mar 24, 2024

I have done simple test with the codes(also glanced the code a little bit), the validators blocks the publishing as expected when the uv names are not being named to map1. image But somehow the font of the error report looks a bit strange where the bold text somehow appear to be much bigger than the normal text. If the debug message and the comment above can be resolved, I will approve the ticket. image

Thank you, I expect this to be fixed with 83fa719

@BigRoy BigRoy requested a review from moonyuet March 24, 2024 18:21
@MustafaJafar MustafaJafar added the community Issues and PRs coming from the community members label Mar 25, 2024
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me. Also tested by loading tha blender made model with map1 uvset into maya host to check if all propagated correctly and all good.
image

note: only small glitch being those non bold typings when messages shown during validation in the publisher

Screenshot 2024-03-25 103145

@LiborBatek
Copy link
Member

Can be merged imho...

@moonyuet moonyuet merged commit e1c20f1 into ynput:develop Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues and PRs coming from the community members size/S type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants