Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DNG support #232

Merged
merged 4 commits into from
Apr 2, 2024
Merged

Conversation

EmberLightVFX
Copy link
Contributor

Changelog Description

This PR adds .dng as an image extension in IMAGE_EXTENSIONS and adds .dng to image, plate and render for the tray publisher.

Additional info

Maybe some good to know about dng:
DNG (digital negativ) is the standard format used for film-scans and used in as good as all projects that has bin filmed on real film.
By default scans ends up in cineon log with a srgb gamut. It's the same as what RedLogFilm uses.

Testing notes:

  1. Publish a dng image or sequence.
  2. Load the dng sequence in Nuke or Fusion

@ynbot ynbot added host: TrayPublisher type: enhancement Improvement of existing functionality or minor addition size/XS labels Mar 25, 2024
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MustafaJafar MustafaJafar added the community Issues and PRs coming from the community members label Mar 26, 2024
@MustafaJafar
Copy link
Contributor

I think Tray publisher addon version should be bumped as this PR updates its settings.
what do you think @iLLiCiTiT ?

@iLLiCiTiT
Copy link
Member

I think Tray publisher addon version should be bumped as this PR updates its settings.

Yes, settings change >>> version bump.

@EmberLightVFX
Copy link
Contributor Author

Yes, settings change >>> version bump.

Where do I bump the tray-publisher version?

@BigRoy
Copy link
Collaborator

BigRoy commented Mar 26, 2024

Yes, settings change >>> version bump.

Where do I bump the tray-publisher version?

Should be this one:

@EmberLightVFX
Copy link
Contributor Author

Should be this one:

Ahh true! I was looking in the client folder... Head is still in OpenPype sometimes

@EmberLightVFX
Copy link
Contributor Author

The linting check failed when I bumped up the version :S no idea why

@BigRoy
Copy link
Collaborator

BigRoy commented Mar 26, 2024

The linting check failed when I bumped up the version :S no idea why

You can ignore that - for now that'll be happening on any commit due to this recent merge #192

Work is being done to resolve that in #196

Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Maybe up to @antirotor or @jakubjezek001 to look into whatever we need to do with that linter stuff.

@iLLiCiTiT iLLiCiTiT merged commit e31343b into ynput:develop Apr 2, 2024
5 of 6 checks passed
@EmberLightVFX EmberLightVFX deleted the enhancement/add_dng_support branch April 2, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues and PRs coming from the community members host: TrayPublisher size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants