Maya: Validate Model Content improve validation message

[BigRoy]

Changelog Description

Validator for model product type content should provide a better error message.

Additional info

Also fix get_invalid actually returning the instance node.

Testing notes:

1. Publish model with invalid geometry, e.g. a proxy shape inside - it should be captured by this validator.

[MustafaJafar]

Tested as user.
It works on my side.

[BigRoy]

Actually - let me actually improve the "description" for this validator. Because this still doesn't look very nice.

[BigRoy]

Report should be improved now.

[MustafaJafar]

This is helpful!

[LiborBatek]

I have ran several different test occasions with following results (in terms of Validation message) for your consideration @BigRoy

Multiple Roots present:

Empty GRP with no geometries at all:

When invalid objects present in the model instance:

And if some Shape not being visible (actually I have turned on Intermediate Shape in the ShapeNode attribs) ...sort of works for this occasion too even tho its not 100% accurate info for user whats causing it and also when triggering Repair it simply removes the object which is a bit destructive imho...but works somewhat

Would be even cooler if it could detect the Intermediate shape and switch it off...and notify this more accurately....however its a bit of edge case aka synthetic circumstance anyway

[LiborBatek]

@BigRoy maybe for the last occasion with Empty Transform we could enhance the detailed message on the right with something like:

Empty transforms found without Shapes or with "Intermediate" shape enabled. Warning: by hitting "Repair" action these will be removed!

or similar. What u think?

[LiborBatek]

Would be nice to adress the occasion when Shape not visible and informing user that Repair will actually delete those invalid entities...

[BigRoy]

@BigRoy maybe for the last occasion with Empty Transform we could enhance the detailed message on the right with something like:

Empty transforms found without Shapes or with "Intermediate" shape enabled. Warning: by hitting "Repair" action these will be removed!

or similar. What u think?

Thanks for the thorough testing. I'd like to argue that the current behavior is actually correct.

The model family exports without construction history and thus should ignore the intermediate objects. As such, to what would be published that is just an "empty mesh". In day to day production I've also never seen a modeler count a Transform with an intermediate object shape under it (which Maya doesn't show in outliner by default, etc.) as a "mesh" - they just see the empty transform and often don't even know that it was containing an intermediate object - which usually happens due to modeling tools and construction history they make. As such, the input node that had the intermediate mesh usually also counts as "history" and thus should be removed.

I'd say, if there's more debate about it we can do so in another PR? @LiborBatek

[LiborBatek]

@BigRoy yeah, I get your point...no need to take such occasion into account

in terms of "improving validation message" I can see some benefits to include that "removal warning" as its not repairing but deleting stuff from the workfile altering it.

And it does not affect the current correct behaviour in any way just improving the message for a user.

Lets merge it anyway...