Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maya: Yeti - Implement writing and loading user variables with a yeti cache #287

Merged
merged 4 commits into from
Apr 26, 2024

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Mar 27, 2024

Changelog Description

Implement writing and loading user variables with a yeti cache

Additional info

Support writing and loading of user variables in a yeti node with the yeticache product type.

Testing notes:

  1. Loading legacy yeti products should work
  2. Publish a new yeti product without user variables should work + loading it + updating it
  3. Publish a new yeti product with user variables should work + loading it + updating it

@ynbot ynbot added size/S host: Maya type: enhancement Improvement of existing functionality or minor addition labels Mar 27, 2024
@MustafaJafar MustafaJafar added the community Issues and PRs coming from the community members label Apr 1, 2024
@tokejepsen tokejepsen assigned tokejepsen and LiborBatek and unassigned tokejepsen Apr 8, 2024
@LiborBatek
Copy link
Member

@BigRoy sorry being ignorant, could u elaborate more on those user variables pls? aka testing steps...thx as Im not sure which are u refering to.

@BigRoy
Copy link
Collaborator Author

BigRoy commented Apr 19, 2024

@BigRoy sorry being ignorant, could u elaborate more on those user variables pls? aka testing steps...thx as Im not sure which are u refering to.

No worries - it's the user variables as created on the Yeti node, like described here - so basically it's like exposing graph internals to global attributes on the node. For example you can promote the "width" of a specific part of the graph to a user variable so it can still be tweaked upon. Giving you more granular control, even if there's a cache file already. The user variables are also described in the Yeti docs here

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested yeti with and without any user variable and all ayon actions works normally...

User being able to Load Manage and lastly Connect Yeti via action in the inventory. No issue were found also with older products published before this PR...

All good!

Here is my asset with user variable loaded and checked if present on the yetiRig asset. Works fine.
Screenshot 2024-04-19 124307

@BigRoy
Copy link
Collaborator Author

BigRoy commented Apr 19, 2024

I have tested yeti with and without any user variable and all ayon actions works normally...

User being able to Load Manage and lastly Connect Yeti via action in the inventory. No issue were found also with older products published before this PR...

All good!

Here is my asset with user variable loaded and checked if present on the yetiRig asset. Works fine. Screenshot 2024-04-19 124307

Actually @LiborBatek this may have been my bad in the testing notes. But they should load to the Yeti Cache product when loading - not just to the loaded yeti rig. So from that yeti rig in your screenshot, publish a cache - that cache should then also on load have the user variables.

@LiborBatek LiborBatek self-requested a review April 19, 2024 12:50
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @BigRoy for noting I have to test also yeti cache product....

So it works fine and with propagating user variables.

Screenshot 2024-04-19 145000

Can be merged i guess...

@moonyuet moonyuet merged commit c52963a into ynput:develop Apr 26, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues and PRs coming from the community members host: Maya size/S type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants