Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maya: Optimize collect file dependencies #331

Merged

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Mar 29, 2024

Changelog Description

Only collect file dependencies if enabled in settings and only collect if renderlayer family is present

Additional info

Now also excludes "duplicate" entries.

Still has the issue that it doesn't work correctly for all udim tiles, etc. The logic is just too simple for that and I believe has been reported before. Anyway, for now this is a good optimization.

The setting is deadline > publish > MayaSubmitDeadline > asset_dependencies

Testing notes:

  1. Collect file dependencies should only run if a renderlayer instance is active.
  2. When enabled in settings, file dependencies should be collected and submitted along to Deadline job
  3. When disabled in settings, file dependencies should not be collected

@ynbot ynbot added size/XS type: enhancement Improvement of existing functionality or minor addition host: Maya labels Mar 29, 2024
@MustafaJafar MustafaJafar added the community Issues and PRs coming from the community members label Apr 1, 2024
@moonyuet moonyuet requested a review from LiborBatek April 2, 2024 13:09
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Maya 2023 successfully and the asset dependencies wont be in the job info parameters when the relevant setting has been disabled.

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, already tested by @moonyuet

@kalisp kalisp merged commit a4fb13d into ynput:develop Apr 5, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues and PRs coming from the community members host: Maya size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants