Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Preparation for split of addon from ayon core #402

Merged

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Prepare codebase for first step in separation of addon from ayon core codebase. Moved client code of applications addon next to server code.

Additional info

This change is preparation for separation of addons into separated repositories. First step will be to move code from modules and hosts next to their coresponding server code under server_addon directory. First candidate was applications addon.

Combination of older addons and newer ayon-core,may cause that the client code is not available. I've added a mapping of milestone version of an addon to be able to detect these cases and log them out. For now it is only applications addon, but more will come.

Modified script creating packages in server_addon to be able to handle client code and custom package.py.

Not sure if logging out the error is enough? Not sure if we should show a message about it?

Testing notes:

There is so much possibilities how to test this,

  1. Run server_addon/create_ayon_addons.py and upload the packages to server.
  2. Create bundle with the packages.
  3. Run AYON launcher.
  4. Everything should be working ok.
  5. When applications addon in the bundle is lowered to any 0.1.x version, AYON launcher should log out warning message.

@ynbot ynbot added size/S type: enhancement Improvement of existing functionality or minor addition labels Apr 10, 2024
@m-u-r-p-h-y m-u-r-p-h-y self-assigned this Apr 11, 2024
Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • created addons
  • uploaded to the server
  • modified dev bundle to use the latest addons
  • launched Ayon in dev mode

all is working as expected, apps are launched correctly (tested, Maya, Nuke, 3dsMax)

@iLLiCiTiT iLLiCiTiT merged commit e7bb981 into develop Apr 11, 2024
1 check failed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/AY-4893_Better-addons-client-code-in-core branch April 11, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants