-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maya: Improve validators for a mesh without geometry (no faces) #409
Maya: Improve validators for a mesh without geometry (no faces) #409
Conversation
Easiest reproducable: `maya.cmds.createNode("mesh")`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested successfully in Maya 2023.
Changelog Description
Improve validations for meshes without any faces/geometry.
Easiest reproducable is using this python script to create a mesh:
Or to simplify it for publishing:
Now publish that mesh as a model with the Validate Mesh NGONs an Validate Mesh UV has map1 UV set validators enabled. Without this PR those validators will error - now they will ignore, or invalidate with PublishValidationError improving the report.
I've also taken the liberty to improve the validation message for the Validate Mesh has map1 UV Set validator
Additional info
We hit an issue where somehow in production where a
mesh
was broken and had no remaining geometry (likely due to an issue with maya's construction history somewhere). How to reproduce that actual real production scenario, I have no idea. But the code provided above creates a mesh with a 'similar' state.Note that a mesh without faces/geometry is still invalid - but it's validated by a dedicated validator generating a better report.
Testing notes: