Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workfile Templates: Fix ayon core refactor usage of correct placeholder data #429

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Apr 17, 2024

Changelog Description

Fix workfile templates since ayon core refactoring family -> product_type

Additional info

Fixes:

# ========
# 'family'
# ========
# Traceback (most recent call last):
#   File "E:\dev\ayon-core\client\ayon_core\pipeline\workfile\workfile_template_builder.py", line 716, in populate_scene_placeholders
#     placeholder_plugin.populate_placeholder(placeholder)
#   File "E:\dev\ayon-core\client\ayon_core\hosts\maya\api\workfile_template_builder.py", line 246, in populate_placeholder
#     self.populate_load_placeholder(placeholder)
#   File "E:\dev\ayon-core\client\ayon_core\pipeline\workfile\workfile_template_builder.py", line 1577, in populate_load_placeholder
#     for repre_entity in self._get_representations(placeholder)
#   File "E:\dev\ayon-core\client\ayon_core\pipeline\workfile\workfile_template_builder.py", line 1471, in _get_representations
#     product_type = placeholder.data["family"]
KeyError: 'family'

Fix is also present in other larger PRs, but they make take some time to get along:

This implements the fix in isolation.

Testing notes:

  1. This should fix workfile templates in ayon core.

@iLLiCiTiT
Copy link
Member

Resolved in #416

@iLLiCiTiT iLLiCiTiT closed this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants