Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maya: Fix VRay Proxies look assigner import #463

Merged

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Apr 29, 2024

Changelog Description

Fixes Maya Look Assigner import in vray_proxies logic.

Additional info

Fixes:

# Error: cannot import name 'lib' from 'openpype.hosts.maya' (C:\Users\Maqina-RTX-01\AppData\Local\Ynput\AYON\addons\core_0.3.1-dev.2\ayon_core\hosts\maya\__init__.py)
# # Traceback (most recent call last):
# #   File "C:\Users\Maqina-RTX-01\AppData\Local\Ynput\AYON\addons\core_0.3.1-dev.2\ayon_core\hosts\maya\api\customize.py", line 116, in <lambda>
# #     command=lambda: show_look_assigner(
# #   File "C:\Users\Maqina-RTX-01\AppData\Local\Ynput\AYON\addons\core_0.3.1-dev.2\ayon_core\hosts\maya\tools\__init__.py", line 21, in show_look_assigner
# #     look_assigner_tool = get_look_assigner_tool(parent)
# #   File "C:\Users\Maqina-RTX-01\AppData\Local\Ynput\AYON\addons\core_0.3.1-dev.2\ayon_core\hosts\maya\tools\__init__.py", line 11, in get_look_assigner_tool
# #     from .mayalookassigner import MayaLookAssignerWindow
# #   File "C:\Users\Maqina-RTX-01\AppData\Local\Ynput\AYON\addons\core_0.3.1-dev.2\ayon_core\hosts\maya\tools\mayalookassigner\__init__.py", line 1, in <module>
# #     from .app import (
# #   File "C:\Users\Maqina-RTX-01\AppData\Local\Ynput\AYON\addons\core_0.3.1-dev.2\ayon_core\hosts\maya\tools\mayalookassigner\app.py", line 21, in <module>
# #     from .widgets import (
# #   File "C:\Users\Maqina-RTX-01\AppData\Local\Ynput\AYON\addons\core_0.3.1-dev.2\ayon_core\hosts\maya\tools\mayalookassigner\widgets.py", line 16, in <module>
# #     from . import commands
# #   File "C:\Users\Maqina-RTX-01\AppData\Local\Ynput\AYON\addons\core_0.3.1-dev.2\ayon_core\hosts\maya\tools\mayalookassigner\commands.py", line 15, in <module>
# #     from .vray_proxies import get_alembic_ids_cache
# #   File "C:\Users\Maqina-RTX-01\AppData\Local\Ynput\AYON\addons\core_0.3.1-dev.2\ayon_core\hosts\maya\tools\mayalookassigner\vray_proxies.py", line 10, in <module>
# #     import ayon_core.hosts.maya.lib as maya_lib

Testing notes:

Not entirely sure when the error occurs - maybe directly when opening the look assigner? Just got it reported to me by an artists.

  1. Maya Look Assigner should work.

@ynbot ynbot added host: Maya size/XS type: bug Something isn't working labels Apr 29, 2024
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't test it but the code looks good.

@iLLiCiTiT iLLiCiTiT merged commit a13bfe1 into ynput:develop Apr 30, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Maya size/XS type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants