-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Max: Add missing workfile creator #47
Merged
iLLiCiTiT
merged 17 commits into
develop
from
enhancement/OP-8111_Publishing-of-Workfiles
Feb 21, 2024
Merged
Max: Add missing workfile creator #47
iLLiCiTiT
merged 17 commits into
develop
from
enhancement/OP-8111_Publishing-of-Workfiles
Feb 21, 2024
+152
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ynbot
added
size/S
type: enhancement
Improvement of existing functionality or minor addition
labels
Feb 13, 2024
BigRoy
reviewed
Feb 13, 2024
BigRoy
reviewed
Feb 13, 2024
BigRoy
reviewed
Feb 13, 2024
BigRoy
reviewed
Feb 13, 2024
iLLiCiTiT
reviewed
Feb 13, 2024
BigRoy
reviewed
Feb 13, 2024
BigRoy
reviewed
Feb 14, 2024
BigRoy
reviewed
Feb 14, 2024
BigRoy
reviewed
Feb 14, 2024
BigRoy
reviewed
Feb 14, 2024
BigRoy
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't test it (don't use Max) but overall code changes look okay on first sight.
iLLiCiTiT
reviewed
Feb 20, 2024
iLLiCiTiT
reviewed
Feb 20, 2024
client/ayon_core/hosts/max/plugins/publish/collect_current_file.py
Outdated
Show resolved
Hide resolved
…r of current file to lower priority for collecting the data
LiborBatek
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Add the missing workfile creator in 3dsMax.
Ported from Openpype: ynput/OpenPype#6203
Additional info
For some reason,
get_subset_name
function can't set the name with the correct variant, although there is variant.It is using the old subset name
workfileAsset
.Testing notes: