Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max: Add missing workfile creator #47

Merged
merged 17 commits into from
Feb 21, 2024

Conversation

moonyuet
Copy link
Member

Changelog Description

Add the missing workfile creator in 3dsMax.
Ported from Openpype: ynput/OpenPype#6203

Additional info

For some reason, get_subset_name function can't set the name with the correct variant, although there is variant.
It is using the old subset name workfileAsset.

Testing notes:

  1. Launch Max via launcher
  2. Load Scene
  3. Open publisher
  4. it should automatically create the workfile instance
  5. you can notice the new container (which is hidden and greyed out) named accordingly
  6. Publish workfile
  7. It should be successfully published.

@ynbot ynbot added size/S type: enhancement Improvement of existing functionality or minor addition labels Feb 13, 2024
@moonyuet moonyuet requested a review from BigRoy February 14, 2024 09:06
@moonyuet moonyuet requested a review from BigRoy February 14, 2024 11:47
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test it (don't use Max) but overall code changes look okay on first sight.

…r of current file to lower priority for collecting the data
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working as expected...

tested in max 2024

Screenshot 2024-02-21 091840

@iLLiCiTiT iLLiCiTiT merged commit 549393f into develop Feb 21, 2024
9 checks passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/OP-8111_Publishing-of-Workfiles branch February 21, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: 3dsmax size/S type: enhancement Improvement of existing functionality or minor addition
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants