Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loader: Don't change controller project on close #491

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented May 7, 2024

Changelog Description

Do not change controller's selected project on close of loader window which causes issues.

Additional info

There is an issue with this approach. When the project change does not happen via project combobox then the combobox does not know that it should be deselected. In case there is no current project (e.g. loader used in tray action) it won't update the expected project and behave like there is no selected project, but it is. After some testing I found out that the change is not needed at all and can be discarted.

Testing notes:

Loader tray action

This is what this PR is fixing.

  1. Open loader tool in tray
  2. Select a project
  3. Close loader tool
  4. Open the loader tool again
  5. The same project should be selected and it's folders are visible

Loader in hosts

Validate that we didn't break expected behavior in hosts.

  1. Launch host of your choice
  2. Open loader tool
  3. Change project to library project
  4. Close loader tool
  5. Open loader tool
  6. Current project with current context should be selected

@ynbot
Copy link
Contributor

ynbot commented May 7, 2024

@iLLiCiTiT iLLiCiTiT requested a review from LiborBatek May 7, 2024 16:14
@ynbot ynbot added size/XS type: bug Something isn't working labels May 7, 2024
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did perform both tests and all working as expected.

All working fine!

@iLLiCiTiT iLLiCiTiT merged commit ae5f716 into develop May 16, 2024
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the bugfix/AY-5234_Loader-Not-refreshing--showing-project-content branch May 16, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants