Loader: Don't change controller project on close #491
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Do not change controller's selected project on close of loader window which causes issues.
Additional info
There is an issue with this approach. When the project change does not happen via project combobox then the combobox does not know that it should be deselected. In case there is no current project (e.g. loader used in tray action) it won't update the expected project and behave like there is no selected project, but it is. After some testing I found out that the change is not needed at all and can be discarted.
Testing notes:
Loader tray action
This is what this PR is fixing.
Loader in hosts
Validate that we didn't break expected behavior in hosts.