-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Substance Painter: Support for exporting maps/layer stacks with specific channels #532
Substance Painter: Support for exporting maps/layer stacks with specific channels #532
Conversation
Task linked: AY-5104 Substance: selective export of layers |
client/ayon_core/hosts/substancepainter/plugins/create/create_textures.py
Outdated
Show resolved
Hide resolved
client/ayon_core/hosts/substancepainter/plugins/create/create_textures.py
Outdated
Show resolved
Hide resolved
client/ayon_core/hosts/substancepainter/plugins/publish/extract_textures.py
Outdated
Show resolved
Hide resolved
…tips edition for export channel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made bunch of misc tests with different conditions for publish
of the texture set
.
All three occasions works well as I was able to produce standard full publish of texture set
, also just picked channel
like base color
or roughness
and finally also test with Use Selected
option.
There is also no malfunction when mutliple publish instances present...again all good!
client/ayon_core/hosts/substancepainter/plugins/create/create_textures.py
Outdated
Show resolved
Hide resolved
client/ayon_core/hosts/substancepainter/plugins/create/create_textures.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
client/ayon_core/hosts/substancepainter/plugins/create/create_textures.py
Show resolved
Hide resolved
…ntation in creator doesn't break the integration
server_addon/substancepainter/server/settings/creator_plugins.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iLLiCiTiT can you check on the code? |
client/ayon_core/hosts/substancepainter/plugins/publish/validate_ouput_maps.py
Outdated
Show resolved
Hide resolved
client/ayon_core/hosts/substancepainter/plugins/publish/validate_ouput_maps.py
Outdated
Show resolved
Hide resolved
client/ayon_core/hosts/substancepainter/plugins/publish/validate_ouput_maps.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
went quickly through the code, looks fine but I couldn't test it
client/ayon_core/hosts/substancepainter/plugins/create/create_textures.py
Outdated
Show resolved
Hide resolved
client/ayon_core/hosts/substancepainter/plugins/publish/validate_ouput_maps.py
Outdated
Show resolved
Hide resolved
client/ayon_core/hosts/substancepainter/plugins/publish/validate_ouput_maps.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside of the open comments the code looks good. I did not do a test run as I do not have Substance Painter available to me currently but the code looks good aside of aforementioned notes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog Description
This PR is to add support for exporting outputs with specific channels defined in the settings and the users can choose to export layer with
use_selection
being enabled.User can add/define their channel map in the ayon project setting, once they add their maps, it would show up in the multiselection options of export channel.
You need to specify your channel type and the name of your channel type(of which name extension you set in your export presets)
Additional info
The template below showed the setting does not support for exporting specific channels
Testing notes:
Without layer stack
With selected layer stack
use_selection
being enabled.General