Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publisher: filter creators based on task #560

Merged
merged 41 commits into from
Jun 10, 2024
Merged

Publisher: filter creators based on task #560

merged 41 commits into from
Jun 10, 2024

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented May 28, 2024 •
edited
Loading

Changelog Description

This provides a way how to limit list of provided Creators in Publisher based on current context. This should
help artists decision which creator they should use.

Creator labels can by copy&pasted from Publisher.

Additional info

If you want to limit which creators should be shown, provide some profile, based on host name and task info.
Put creator identifier to Allowed Creator Labels.

Testing notes:

  1. configure ayon+settings://core/tools/creator/filter_creator_profiles?project=ayon_test
core_tools_filter_creators
  1. check that configured profile was applied and appropriate creator is shown/not shown in middle column with list of creators inside of Publisher

@ynbot
Copy link
Contributor

ynbot commented May 28, 2024

Task linked: AY-5539 define creators per task

@ynbot ynbot added type: enhancement Improvement of existing functionality or minor addition size/XS labels May 28, 2024
@kalisp kalisp mentioned this pull request May 28, 2024
Merged
BigRoy
BigRoy reviewed May 28, 2024
View reviewed changes
client/ayon_core/tools/publisher/control.py Outdated Show resolved Hide resolved
client/ayon_core/tools/publisher/control.py Outdated Show resolved Hide resolved
client/ayon_core/tools/publisher/control.py Show resolved Hide resolved
client/ayon_core/tools/publisher/control.py Outdated Show resolved Hide resolved
iLLiCiTiT
iLLiCiTiT reviewed May 28, 2024
View reviewed changes
server/settings/tools.py Outdated Show resolved Hide resolved
iLLiCiTiT
iLLiCiTiT reviewed May 28, 2024
View reviewed changes
server/settings/tools.py Outdated Show resolved Hide resolved
iLLiCiTiT
iLLiCiTiT reviewed May 28, 2024
View reviewed changes
server/settings/tools.py Outdated Show resolved Hide resolved
@64qam 64qam requested a review from MilaKudr May 28, 2024 18:06
kalisp and others added 9 commits May 29, 2024 12:12
@kalisp @iLLiCiTiT
Fix default factory
170b1ab 
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
@kalisp @iLLiCiTiT
Fix formatting
ea626e1 
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
@kalisp @iLLiCiTiT
Fix formatting
34041b3 
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
@kalisp @iLLiCiTiT
Fix formatting
5e95565 
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
@kalisp
Merge branch 'develop' of https://github.com/ynput/ayon-core into enh…
1ac4223 
…ancement/AY-5539_define-creators-per-task
@kalisp
Merge remote-tracking branch 'origin/enhancement/AY-5539_define-creat…
e074268 
…ors-per-task' into enhancement/AY-5539_define-creators-per-task
@kalisp
AY-5539 - remove explicit check for traypublisher
719e5aa 
Safely return task_type only if task_entity exits.
@kalisp
AY-5539 - added project settings to CreatorContext
3c287e1
@kalisp @iLLiCiTiT
Use host_names in Settings
cafb4c9 
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
BigRoy
BigRoy reviewed May 31, 2024
View reviewed changes
server/settings/tools.py Outdated Show resolved Hide resolved
BigRoy
BigRoy reviewed May 31, 2024
View reviewed changes
server/settings/tools.py Outdated Show resolved Hide resolved
kalisp and others added 2 commits May 31, 2024 13:31
@kalisp @BigRoy
Updated description
d2d05f6 
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
@kalisp
AY-5539 - possible speedup of resolution
0fe6526
@kalisp kalisp requested a review from iLLiCiTiT June 3, 2024 10:07
@kalisp kalisp requested a review from BigRoy June 6, 2024 09:54
BigRoy
BigRoy approved these changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test the code, but overall the code changes look good. Might need some testing by someone still if it hasn't been thoroughly tested yet.

@kalisp kalisp merged commit 0a702fe into develop Jun 10, 2024
1 check passed
@kalisp kalisp deleted the enhancement/AY-5539_define-creators-per-task branch June 10, 2024 08:46
@BigRoy BigRoy mentioned this pull request Jul 3, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MilaKudr MilaKudr MilaKudr approved these changes

@64qam 64qam 64qam approved these changes

@MustafaJafar MustafaJafar MustafaJafar approved these changes

@BigRoy BigRoy BigRoy approved these changes

@LiborBatek LiborBatek Awaiting requested review from LiborBatek

@iLLiCiTiT iLLiCiTiT Awaiting requested review from iLLiCiTiT

Assignees

@LiborBatek LiborBatek

Labels
size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
PR reviewing
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@kalisp @ynbot @BigRoy @MustafaJafar @64qam @iLLiCiTiT @MilaKudr @LiborBatek