Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max: Implementation of Validate Render Passes #57

Merged
merged 25 commits into from
Mar 18, 2024

Conversation

moonyuet
Copy link
Member

Changelog Description

Ported from Openpype: ynput/OpenPype#6138
This PR is to enhance the current validator of checking the render output before deadline publish. It does the following:

  1. The validator Render Output for Deadline would be renamed as Validate Render Passes
  2. The validator would not only check on the invalid render output folder but the invalid filename of render passes.

Additional info

n/a

Testing notes:

  1. Launch Max via Launcher
  2. Open a Renderable Scene
  3. Create Some AOVs in Render Setting
  4. Create Render Instance with your preferred camera(s)
  5. Publish
  6. If the AOVs dont have invalid name or render output folder doesn't match the max scene name, it will error out.
  7. You can perform repair action once you encounter 7.

@ynbot ynbot added size/S host: 3dsmax module: Deadline type: enhancement Improvement of existing functionality or minor addition labels Feb 14, 2024
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems working normally and as supposed to. When some invalid file name and/or file path then it correctly kicks in and rise error for user.

Screenshot 2024-03-06 140501

After Repair action all Validates fine and without any errors...

@moonyuet moonyuet requested a review from BigRoy March 18, 2024 11:16
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small comments - but overall looks good.

@LiborBatek LiborBatek self-requested a review March 18, 2024 14:03
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working ok and no issues were found.

@moonyuet moonyuet merged commit 7052038 into develop Mar 18, 2024
@moonyuet moonyuet deleted the enhancement/OP-7074_Validate-Render-Passes branch March 18, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: 3dsmax module: Deadline size/S type: enhancement Improvement of existing functionality or minor addition
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants