-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Cleanups after addons movement #606
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ynbot
added
host: 3dsmax
host: Houdini
host: Maya
host: Nuke
host: Photoshop
size/S
host: Substance Painter
host: TrayPublisher
module: RoyalRender
type: enhancement
Improvement of existing functionality or minor addition
labels
Jun 6, 2024
iLLiCiTiT
requested review from
kalisp,
MustafaJafar,
antirotor,
jakubjezek001 and
moonyuet
June 6, 2024 16:49
moonyuet
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested successfully in max and substance painter
antirotor
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
host: Houdini
host: Maya
host: Nuke
host: Substance Painter
host: TrayPublisher
host: 3dsmax
module: RoyalRender
size/S
type: enhancement
Improvement of existing functionality or minor addition
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Cleanup after movement of most of the hosts and modules out of ayon-core.
Additional info
Modified a little loading logic in addon base. Use up-to-date class names in readme. Don't try to support backport compatible imports using
openpype
.Added
client_dir
andversion.py
to all moved addons and use the value on client addon class.Removed
wsrpc_aiohttp
from ayon-core dependencies as it is not used anywhere in the addon.Testing notes: