-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Applications addon decouple of logic #621
Merged
Merged
+402
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ynbot
added
size/M
type: enhancement
Improvement of existing functionality or minor addition
labels
Jun 10, 2024
iLLiCiTiT
requested review from
kalisp,
64qam,
antirotor,
jakubjezek001 and
MilaKudr
June 10, 2024 13:20
64qam
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but someone else should also test it.
antirotor
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems to work fine, not tested it in all combinations though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
host: Houdini
host: Maya
host: Nuke
host: Resolve
host: Substance Painter
host: 3dsmax
module: Shotgrid
size/M
type: enhancement
Improvement of existing functionality or minor addition
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Moved some amount of applications logic to applications addon. Core still has to know some logic of applications addon but not all of it.
Additional info
The biggest disadvantage is that core addon has to know how to create action classes, their icons, labels if are enabled/disabled tc. which should be in charge of the applications addon. Applications addon is also providing the icons.
Selection object in launcher has support to get project settings.
Applications addon did not yet change the logic, only has it available, so old ayon core will still work, and new ayon-core can work with both new and old applications addon versions.
Because we're planning how applications addon work this is "must have" PR.
Testing notes: