Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applications: Handle additional applications correctly #63

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Add additional applications correctly to list of applications.

Additional info

Additional applications is not a dictionary but list.

Testing notes:

  1. Add any additional application in Applications settings
  2. It should not raise error when ApplicationsManager is created (e.g. in Launcher tool)

@ynbot ynbot added size/XS type: bug Something isn't working labels Feb 14, 2024
@iLLiCiTiT iLLiCiTiT added bug and removed size/XS type: bug Something isn't working labels Feb 14, 2024
Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just checkedout this PR and the error vanished!

@iLLiCiTiT iLLiCiTiT merged commit f9ab339 into develop Feb 14, 2024
8 checks passed
@iLLiCiTiT iLLiCiTiT deleted the bugfix/additional-applications-fix branch February 14, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants